Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SacessOptimizer: expose more hyperparameters #1459

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 14, 2024

  • Introduces a new SacessOptions class to collect SacessOptimizer hyperparameters and makes some previously hard-coded values configurable.

    Closes SacessOptimizer - expose more hyperparameters #1458

  • Fixes a mismatch in adaptation conditions between the original SaCeSS implementation and SacessOptimizer

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.39%. Comparing base (36eec04) to head (58dc3bd).

Files with missing lines Patch % Lines
pypesto/optimize/ess/sacess.py 78.12% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1459      +/-   ##
===========================================
- Coverage    83.44%   83.39%   -0.05%     
===========================================
  Files          160      160              
  Lines        13474    13499      +25     
===========================================
+ Hits         11243    11258      +15     
- Misses        2231     2241      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review September 16, 2024 07:42
pypesto/optimize/ess/sacess.py Outdated Show resolved Hide resolved
@dweindl dweindl merged commit 5c58374 into ICB-DCM:develop Sep 16, 2024
14 of 18 checks passed
@dweindl dweindl deleted the sacess_options branch September 16, 2024 12:02
This was referenced Sep 17, 2024
@dweindl dweindl linked an issue Sep 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SacessOptimizer - expose more hyperparameters
4 participants