Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume all pair_coeff come with a path #23

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Feb 24, 2022

At least for MTP potentials the format for the lammps potential is like

pair_style mlip mlip.ini
pair_coeff * *

where mlip.ini is the potential specific file. That means when
fix_paths tries to look a filepath to adjust in pair_coeff it won't find
anything and crash. This also means fix_paths might have to be applied
to pair_style also, but I haven't done that here. :/

I could not test further if there's issues with MTPs, because I'll need to custom build the lammps python first, so I am not sure if this change is the best way about it, but at least this quick fix got me somewhere calphy actually starts to try and run a calculation.

At least for MTP potentials the format for the lammps potential is like

pair_style mlip mlip.ini
pair_coeff * *

where mlip.ini is the potential specific file.  That means when
fix_paths tries to look a filepath to adjust in pair_coeff it won't find
anything and crash.  This also means fix_paths might have to be applied
to pair_style also, but I haven't done that here. :/
@srmnitc
Copy link
Member

srmnitc commented Feb 24, 2022

@pmrv This might have a bit more far reaching consequences. Similar style is used when fixing hybrid pair styles, for example here. I will check it with the pair style you provided above.

@srmnitc
Copy link
Member

srmnitc commented Feb 25, 2022

@pmrv Calphy uses pair hybrid/scaled method and applies the same potential twice. When this is done, would the commands look like this?

pair_style       hybrid/scaled 0.5 mlip mlip.ini 0.5 mlip mlip.ini
pair_coeff       * * mlip mlip.ini 1
pair_coeff       * * mlip mlip.ini 2

The 0.5s above are just the scale for each potential. I am not sure if this works, but could it be something that you can check? I feel specifying a file in the pair_style is not so common in LAMMPS, but I assume this would be too difficult to change.

@pmrv
Copy link
Contributor Author

pmrv commented Feb 25, 2022

@pmrv This might have a bit more far reaching consequences. Similar style is used when fixing hybrid pair styles, for example here. I will check it with the pair style you provided above.

I had fear as much. :|

@pmrv
Copy link
Contributor Author

pmrv commented Feb 25, 2022

@pmrv Calphy uses pair hybrid/scaled method and applies the same potential twice. When this is done, would the commands look like this?

pair_style       hybrid/scaled 0.5 mlip mlip.ini 0.5 mlip mlip.ini
pair_coeff       * * mlip mlip.ini 1
pair_coeff       * * mlip mlip.ini 2

The 0.5s above are just the scale for each potential. I am not sure if this works, but could it be something that you can check? I feel specifying a file in the pair_style is not so common in LAMMPS, but I assume this would be too difficult to change.

Sure, I'll give it a try manually on the cluster version today.

@srmnitc srmnitc merged commit 9ab37bb into ICAMS:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants