Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Code for IBM i onEvent by subscribe #558

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

sebjulliand
Copy link
Collaborator

Since Code for IBM i v2.12, the onEvent method has been deprecated (and will be removed in v3.0) and must be replaced by subscribe.

This PR takes care of this replacement.

Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Aug 19, 2024
@sebjulliand sebjulliand self-assigned this Aug 19, 2024
Copy link
Collaborator

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting ahead on this change. Just 2 comments and it should be good to merge.

src/testing/index.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
SanjulaGanepola and others added 3 commits August 19, 2024 11:06
Signed-off-by: Sanjula <Sanjula.Ganepola@ibm.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Copy link
Collaborator

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@SanjulaGanepola SanjulaGanepola merged commit 1c8c643 into IBM:main Aug 19, 2024
3 checks passed
@sebjulliand sebjulliand deleted the feature/codeforisubscribe branch August 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants