Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix source orbit enablement for Migrate Source #412

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

edmundreinhardt
Copy link
Member

Migrate Source was missing the Clean up tab because the sourceOrbitEnabled() was returning false.

This has been fixed.

Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
@edmundreinhardt edmundreinhardt requested review from worksofliam and irfanshar and removed request for worksofliam March 22, 2024 21:55
@irfanshar
Copy link
Collaborator

Still not seeing the Clean Up Tab

image

@edmundreinhardt
Copy link
Member Author

Hi Irfan, I would have to merge the PR and release it for you to get it from the Marketplace
In the meantime, the branch could be checked out and a vsix built and loaded into VS Code

@irfanshar
Copy link
Collaborator

Hi Irfan, I would have to merge the PR and release it for you to get it from the Marketplace In the meantime, the branch could be checked out and a vsix built and loaded into VS Code

I was able to get this result by checking out the branch and Running the Extension locally.

This achieves the same result, I believe
image

@edmundreinhardt edmundreinhardt merged commit d8c2080 into main Mar 25, 2024
4 checks passed
@edmundreinhardt edmundreinhardt deleted the fix/406_source_orbit_missing_in_migrate branch March 25, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Source Missing 'Clean Up' logic provided by Source Orbit
2 participants