Fix/360 run action build current wrong path #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
… - with tests Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Needs to survive being persisted in .env files Needs to be validate as valid object Needs to be escaped before being pased to `liblist` PASE command Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Signed-off-by: Edmund Reinhardt <edmund.reinhardt@ca.ibm.com>
Because this pull request was requested before the double quoted name fix was meged into main, but the fixes were present in this branch, so git thinks it is a conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue 360
When the
runActioncommand is run from the project heading in theProject Explorerview, (see below)the path passed in to the Code 4 i
runActioncommand is the path of the file in the active editor (if that file is in the project), otherwise it is the path of the project.By this logic a
Build Allcommand will succeed not matter what file is in the active editor butBuild currentwill not work in that scenario as it is not clear what is meant.Thanks Liam for writing the code