Fix missing deleted files in sub-directories #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanjula Ganepola <sanjulagane@gmail.com>
edmundreinhardt
approved these changes
Feb 19, 2024
| @@ -31,9 +32,10 @@ export default class SourceDirectory extends TreeItem implements ProjectExplorer | |||
|
|
|||
| for (const child of this.sourceInfo.children) { | |||
| try { | |||
| const statResult = await workspace.fs.stat(child.localUri); | |||
There was a problem hiding this comment.
THANK YOU for removing the heavy stat() call!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
@edmundreinhardt Your change in #327 was good, but only showed deleted files at the root of the project. This PR includes the logic you added but when also expanding directories. I also removed some duplicate code as the
DeletedFileclass can simply extendSourceFile.