Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/unet #67

Merged
merged 19 commits into from
Aug 20, 2024
Merged

Add/unet #67

merged 19 commits into from
Aug 20, 2024

Conversation

Joao-L-S-Almeida
Copy link
Member

Experimental draft to include support for mmsegmentation decoders.

@Joao-L-S-Almeida
Basic modules for testing unet
edc2bbe 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
This module is not required
d96a3e1 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Factory and wrapper
585f6f0 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Adjusts for allowing tests
162da74 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Merge branch 'main' of github.com:IBM/terratorch into add/unet
aefcf02
@Joao-L-S-Almeida
Minor improvements
06d883d 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Jul 31, 2024
@Joao-L-S-Almeida
try-except hiddens the output
fccf7fc 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Updating requirements
0a85002 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Updating U-Net wrapper
862746e 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
U-Net testing config file
aad1254 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
vanilla U-Net tests
c838fd2 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Wrapper and Factory needs be adapted
3d9cd47 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
New config files to test mmseg models
2a0f80a 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida linked an issue Aug 6, 2024 that may be closed by this pull request
Support for U-net from mmseg in terratorch #80
Open
@Joao-L-S-Almeida
Updated generic U-Net factory
f22d23b 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>

Config file to test U-Net

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>

mmsegmentation needs a special installation process

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>

mmseg requires some extra dependencies

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
More images to perform tests
7c75816 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Autometic test for U-Net
5868f82 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Merging updates from main
c177911 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida marked this pull request as ready for review August 7, 2024 18:32
romeokienzler
romeokienzler approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@romeokienzler romeokienzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict lgtm

very clean code, low chance of breaking existing code

@romeokienzler
Copy link
Collaborator

@Michal-Muszynski
can you do a
git checkout add/unet
pip install --upgrade .

Then share your feedback please?

@Joao-L-S-Almeida
Circumvent boring minor issue for now
44f0597 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Missing dependency
9f7eca0 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@romeokienzler
Copy link
Collaborator

@Joao-L-S-Almeida to merge

@Joao-L-S-Almeida Joao-L-S-Almeida merged commit cbc98f1 into main Aug 20, 2024
1 of 6 checks passed
@CarlosGomes98 CarlosGomes98 deleted the add/unet branch October 2, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeokienzler romeokienzler romeokienzler approved these changes

@CarlosGomes98 CarlosGomes98 Awaiting requested review from CarlosGomes98

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for U-net from mmseg in terratorch
2 participants
@Joao-L-S-Almeida @romeokienzler