feat: report duplicated env vars in stepTemplate.env

IBM · Oct 27, 2020 · 5c1baa2 · 5c1baa2
1 parent 961ff93
commit 5c1baa2
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/regression-tests/__snapshots__/regresion.test.js.snap b/regression-tests/__snapshots__/regresion.test.js.snap
@@ -786,6 +786,22 @@ Array [
     "path": "./regression-tests/no-duplicate-env.yaml",
     "rule": "no-latest-image",
   },
+  Object {
+    "level": "error",
+    "loc": Object {
+      "endColumn": 18,
+      "endLine": 48,
+      "range": Array [
+        733,
+        736,
+      ],
+      "startColumn": 15,
+      "startLine": 48,
+    },
+    "message": "StepTemplate has env variable 'FOO' duplicated in task 'no-duplicate-env-2'.",
+    "path": "./regression-tests/no-duplicate-env.yaml",
+    "rule": "no-duplicate-env",
+  },
   Object {
     "level": "warning",
     "loc": Object {

diff --git a/src/rules/no-duplicate-env.ts b/src/rules/no-duplicate-env.ts
@@ -1,5 +1,16 @@
 export default (docs, tekton, report) => {
   for (const task of Object.values<any>(tekton.tasks)) {
+    if (task.spec.stepTemplate && task.spec.stepTemplate.env) {
+      const templateEnvVars = new Set();
+      for (const env of task.spec.stepTemplate.env) {
+        if (!templateEnvVars.has(env.name)) {
+          templateEnvVars.add(env.name);
+        } else {
+          report(`StepTemplate has env variable '${env.name}' duplicated in task '${task.metadata.name}'.`, env, 'name');
+        }
+      }
+    }
+
     for (const step of task.spec.steps) {
       if (!step.env) continue;
       const envVariables = new Set();