Skip to content

Commit

Permalink
Merge pull request #34 from IBM/si-deprecation
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Deprecating Security Insights
  • Loading branch information
ntkumar1 authored Aug 4, 2022
2 parents 7e08c54 + e4fa001 commit 8ec9c21
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 9,054 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
if: "!startsWith(github.event.head_commit.message, 'chore') && !startsWith(github.ref, 'refs/tags/v')"
strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: [3.7, 3.8, 3.9]
steps:
- uses: actions/checkout@v1

Expand All @@ -28,7 +28,7 @@ jobs:
strategy:
max-parallel: 2
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: [3.7, 3.8, 3.9]
steps:
- name: setup extensions
uses: actions/checkout@v1
Expand Down Expand Up @@ -56,7 +56,6 @@ jobs:
- name: running integration tests
env:
ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }}
FINDINGS_ENV: ${{ secrets.FINDINGS_ENV }}
CONFIGURATION_GOVERNANCE_ENV: ${{ secrets.CONFIGURATION_GOVERNANCE_ENV }}
RESOURCE_GROUP_ID: ${{ secrets.RESOURCE_GROUP_ID }}
run: build/testScript.sh
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ IBM Cloud services:

Service Name | Module Name | Imported Class Name
--- | --- | ---
[Findings](https://cloud.ibm.com/apidocs/security-compliance/findings) | findings_v1 | FindingsV1
[Configuration Governance](https://cloud.ibm.com/apidocs/security-compliance/config) | configuration_governance_v1 | ConfigurationGovernanceV1

## Prerequisites
Expand All @@ -56,7 +55,7 @@ Service Name | Module Name | Imported Class Name

* An [IBM Cloud][ibm-cloud-onboarding] account.
* An IAM API key to allow the SDK to access your account. Create one [here](https://cloud.ibm.com/iam/apikeys).
* Python 3.6 or above.
* Python 3.7 or above.

## Installation

Expand Down
1 change: 0 additions & 1 deletion build/testScript.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
set -euo pipefail

curl https://us-south.functions.appdomain.cloud/api/v1/web/e6b54af6-ab44-4149-a8e4-e906dcc58136/default/secadvstg-location-shift.json
echo "${FINDINGS_ENV}" | base64 -d >> findings_v1.env
echo "${CONFIGURATION_GOVERNANCE_ENV}" | base64 -d >> configuration_governance_v1.env
python -m pytest test/integration
Loading

0 comments on commit 8ec9c21

Please sign in to comment.