-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The gopkg.in import path can't be used with recent Go versions while the README file claims otherwise #1510
Comments
See: - #16 - IBM/sarama#1510 [#169233688]
Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur. |
Still haven't been resolved apparently :/ |
I have same error. |
Apparently the fix for this is to use |
@babolivier thanks! I'm wondering if we should remove the references to |
I think gopkg.in should go away, I see no reason for using it anymore. |
Yeah same, now that Go natively supports versioning dependencies gokpg.in has no real use anymore. |
@babolivier want to give it a try and send a PR? |
Sure, will do that tomorrow :) |
@babolivier this would help |
Most people use this package as instructed by the README, using the IMHO changing the README is a breaking change (breaking import path) and the right answer is changing the import path within this repository to |
Ugh, looks like I got distracted by work and forgot about this. I'll try to get something out soon. |
Migrate to go modules. The `go.mod` file is not committed into the repository and contains entries for dependencies exclusively needed by the repository and none of the integrations. This is so because we want the importing program to have the final word in deciding versions. As a side-effect, we were forced to update the import path of what was formerly `gopkg.in/Shopify/sarama.v1` to `github.com/Shopify/sarama`. For more details, please see: IBM/sarama#1510 Additionally, CI change were introduced which reduce time by about 50%.
One workaround is using
|
Migrate to go modules. The `go.mod` file is not committed into the repository and contains entries for dependencies exclusively needed by the repository and none of the integrations. This is so because we want the importing program to have the final word in deciding versions. As a side-effect, we were forced to update the import path of what was formerly `gopkg.in/Shopify/sarama.v1` to `github.com/Shopify/sarama`. For more details, please see: IBM/sarama#1510 Additionally, CI change were introduced which reduce time by about 50%.
Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur. |
Using gopkg.in doesn't work for versions >1.20.1 as once a `go.mod` file exists, the go tooling enforces that the import path must match. Fixes #1510 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Because the go.mod file mentions
github.com/Shopify/sarama
as the package's canonical import path,go get gopkg.in/Shopify/sarama.v1
results in the following with Go 1.13:The README file claims that the
gopkg.in
is usable with all recent versions of Go, while it's apparently not.The text was updated successfully, but these errors were encountered: