-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CP4D Authentication): add ssl verification for self-signed certificates #147
Conversation
to elaborate a bit more on this, these changes are for the Authentication step (getting a token). During regular SDK calls we can still pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change look good, but we just need to add "verify" to the docstrings of each function that it was added to...
…ficates Signed-off-by: Luc Exposito <luc.braunexposito@gmail.com> Signed-off-by: LExposito <luc.braunexposito@gmail.com>
Signed-off-by: LExposito <luc.braunexposito@gmail.com>
Docstrings are updated ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [3.16.0](v3.15.3...v3.16.0) (2022-08-01) ### Features * **CP4D Authentication:** add ssl verification for self-signed certificates ([#147](#147)) ([a16685d](a16685d))
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
These modifications allow the user to have a self-signed certificate in the SSL verification process when authenticating to an STT instance on CP4D.
The
verify
attribute is used by the requests python module to indicate the path to a custom CA Bundle (resquests documentation).With these changes, it wont be necessary to disable ssl verification anymore when using a self-signed certificate with STT on CP4D.