Fixed issue where fs.readdirSync fails when both recursive and withFileTypes. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v1.1.0
…rSync it breaks (a potential node.js bug).
yemi-kelani
force-pushed
the
read-dir-bugfix
branch
from
76ab9c7 to
fce03fc
Compare
yemi-kelani
force-pushed
the
read-dir-bugfix
branch
from
83e8dc1 to
ad70881
Compare
yemi-kelani
force-pushed
the
read-dir-bugfix
branch
from
ad70881 to
83bbbc7
Compare
yemi-kelani
force-pushed
the
develop
branch
2 times, most recently
from
b7d472b to
9904fd0
Compare
yemi-kelani
force-pushed
the
read-dir-bugfix
branch
from
83bbbc7 to
76ab9c7
Compare
yemi-kelani
force-pushed
the
read-dir-bugfix
branch
from
76ab9c7 to
1d99f8e
Compare
yemi-kelani
force-pushed
the
read-dir-bugfix
branch
from
1d99f8e to
83bbbc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a node.js issue where
fs.readdirSyncwasn't reliably reading the filesystem after doing a clean install of the vscode extension and running npm install. I'm not sure why I just started encountering this error now but this PR rewrites thegetDirectoryContentfunction to not userecursivewithfs.readdirSyncand adds error handling to be cautiousI was using node
v18.17.1which is the version others had the issue on nodejs/node#51773Also allow collection names and namespaces to be initialized with underscores in them _