Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README.md): update min version of node to be 18 #279

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

padamstx
Copy link
Member

This project's package.json has specified version 18 as the min node version for a while now. This commit just updates the README.md to reflect that.

@padamstx padamstx requested a review from dpopp07 July 24, 2024 14:47
@padamstx padamstx self-assigned this Jul 24, 2024
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! One small change to make though

README.md Outdated Show resolved Hide resolved
This project's package.json has specified version 18 as the min node version
for a while now.  This commit just updates the README.md to reflect that.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit 0297e07 into main Jul 24, 2024
4 checks passed
@padamstx padamstx deleted the update-readme branch July 24, 2024 15:09
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants