Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct Link Changes for VLAN Mapping Dedicated Feature #161

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

MalarvizhiK
Copy link
Member

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@MalarvizhiK
Copy link
Member Author

My local test cases are passing

------------------------------
malark@Malars-MacBook-Pro networking-go-sdk % go test -v ./directlinkv1
=== RUN   TestDirectLinkV1
Running Suite: DirectLinkV1 Suite
=================================
Random Seed: 1709743568
Will run 328 of 328 specs
••
Ran 328 of 328 Specs in 524.008 seconds
SUCCESS! -- 328 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestDirectLinkV1 (524.10s)
PASS
ok  	github.com/IBM/networking-go-sdk/directlinkv1	525.320s

Copy link
Collaborator

@sridhargk sridhargk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MalarvizhiK MalarvizhiK merged commit bb17b0e into master Mar 7, 2024
3 checks passed
@kennburger kennburger deleted the ded-vlan-mapping branch March 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants