build: remove downloading of credentials #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nan2iz
reviewed
Oct 18, 2021
appveyor.yml
Outdated
| @@ -19,7 +19,7 @@ environment: | |||
| secure: +B2bs86RVtJtlbkB+cTf9bkqnNlFJi/PbBBPzR5jlUlLLZoOc+ZgqgQLwee4tCT+ #pragma: whitelist secret | |||
| install: | |||
| # Get the latest stable version of Node.js or io.js | |||
| - ps: Install-Product node $env:nodejs_version | |||
| - ps: Install-Product node 12.13.0 | |||
There was a problem hiding this comment.
do you want to update nodejs_version variable instead of put the actual version here?
But I'm okay with this too.
There was a problem hiding this comment.
yes, I'm wondering if we were setting this on appveyor
There was a problem hiding this comment.
ah sorry i missed this. Yeah that would be good - where do we define nodejs_version?
There was a problem hiding this comment.
I found this appveyor/ci#2921. I think it defaults to the latest version, but we can set it on the yaml file.
Merged
nan2iz
approved these changes
Oct 20, 2021
nan2iz
reviewed
Oct 20, 2021
nan2iz
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes downloading of internal watson service credentials in the core build process.