Skip to content

Commit

Permalink
Revert "Support scanning multiple git repositories in one invocation." (
Browse files Browse the repository at this point in the history
Yelp#170)

This reverts commit 8aa90ee.

Temporarily revert the offending commit to prevent scan missing on old git version. The upstream issue is Yelp#220

After this quick revert, we lose the feature of scanning multiple repos at once. But it should block some of our user from using detect-secrets with old version git.

We should investigate a better fix later.
  • Loading branch information
XIANJUN ZHU authored and justineyster committed Jun 24, 2020
1 parent 8e42e97 commit 8ac86a7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions detect_secrets/core/baseline.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
import re
import subprocess

from detect_secrets import util
from detect_secrets.core.log import get_logger
from detect_secrets.core.secrets_collection import SecretsCollection


log = get_logger(format_string='%(message)s')


Expand Down Expand Up @@ -285,8 +283,8 @@ def _get_git_tracked_files(rootdir='.'):
git_files = subprocess.check_output(
[
'git',
'-C', rootdir,
'ls-files',
rootdir,
],
stderr=fnull,
)
Expand Down

0 comments on commit 8ac86a7

Please sign in to comment.