Minor fix.

Signed-off-by: Revital Sur <eres@il.ibm.com>
IBM · May 16, 2024 · a735dd3 · a735dd3
1 parent 8ce27c0
commit a735dd3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/kfp/kfp_ray_components/Dockerfile b/kfp/kfp_ray_components/Dockerfile
@@ -19,8 +19,6 @@ COPY --chown=ray:users kfp_support_lib/ kfp_support_lib/
 RUN cd kfp_support_lib && pip install --no-cache-dir -e .
 # remove credentials-containing file
 RUN rm requirements.txt
-RUN rm kfp_support_lib/
-RUN rm data-processing-lib/
 
 
 

diff --git a/kfp/transform_workflows/.make.transforms_workflows b/kfp/transform_workflows/.make.transforms_workflows
@@ -26,7 +26,7 @@ endef
 .transforms_workflows.compile-pipeline:
 	. ${VENV_ACTIVATE} && ${PYTHON} ${WF_NAME}.py
 
-%.yaml: %.py ${REPOROOT}/.make.versions ${REPOROOT}/kfp/requirements.env
+%.yaml: %.py ${REPOROOT}/.make.versions ${REPOROOT}/kfp/requirements.env ${REPOROOT}/data-processing-lib/ ${REPOROOT}/kfp/kfp_support_lib/
 	$(MAKE) .transforms_workflows.reconcile-requirement PIPELINE_FILE=$<
 	$(MAKE) .transforms_workflows.compile-pipeline WF_NAME=$(shell (basename $< .py))
 
@@ -38,12 +38,11 @@ endef
 		cd ${REPOROOT} && make setup;  \
 	fi
 ifeq ($(USE_DEV_IMAGES), 1)
-	cd ${TRANSFORM_SRC} && $(MAKE) image && $(MAKE) load-image
 	cd ${REPOROOT}/kfp/kfp_ray_components && $(MAKE) image && $(MAKE) load-image
 endif
 	. ${VENV_ACTIVATE}  && ${PYTHON} -m kfp_support.workflow_support.utils.pipelines_tests_utils -c "sanity-test" -p ${CURDIR}/${PIPELINE_FILE}
 
-${VENV_ACTIVATE}: ${REPOROOT}/.make.versions ${REPOROOT}/kfp/requirements.env ${REPOROOT}/kfp/kfp_ray_components/requirements.txt
+${VENV_ACTIVATE}: ${REPOROOT}/.make.versions ${REPOROOT}/kfp/requirements.env ${REPOROOT}/kfp/kfp_ray_components/requirements.txt ${REPOROOT}/data-processing-lib/ ${REPOROOT}/kfp/kfp_support_lib/
 	@# Help: Create the virtual environment common to all workflows
 	rm -rf ${REPOROOT}/kfp/transform_workflows/venv
 	$(PYTHON) -m venv ${REPOROOT}/kfp/transform_workflows/venv