Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eu-es region #37

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat: support eu-es region #37

merged 2 commits into from
Nov 10, 2023

Conversation

omar-albastami
Copy link
Collaborator

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

omar-albastami and others added 2 commits November 10, 2023 10:07
* feat(toolchain): add eu-es region

Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>

* fix: lint

Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>

---------

Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Co-authored-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com>
@omar-albastami omar-albastami merged commit b79698d into main Nov 10, 2023
3 checks passed
@omar-albastami omar-albastami deleted the eu-es branch November 10, 2023 17:46
briangleeson pushed a commit that referenced this pull request Nov 10, 2023
# [1.4.0](v1.3.1...v1.4.0) (2023-11-10)

### Bug Fixes

* dir fix to Makefile ([22f0f55](22f0f55))

### Features

* bump SDK version ([#38](#38)) ([347f6fb](347f6fb))
* support eu-es region ([#37](#37)) ([b79698d](b79698d)), closes [#35](#35)
@briangleeson
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants