Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump SDK version #38

Merged
merged 5 commits into from
Nov 10, 2023
Merged

feat: bump SDK version #38

merged 5 commits into from
Nov 10, 2023

Conversation

omar-albastami
Copy link
Collaborator

PR summary

Current release is failing because its looking for __version__ = '1.3.1', which it can't find since there are double quotes instead of single.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Omar Al Bastami added 4 commits November 8, 2023 14:39
feat(toolchain): add eu-es region
61ab7a9 
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
fix: lint
61f317a 
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Merge branch 'main' of https://github.com/IBM/continuous-delivery-pyt…
3ba6a3d 
…hon-sdk
fix: replace double quotes with single quotes in version
f79ad93 
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
fix: exclude version.py from linter to avoid deployment errors
4a79ce5 
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
@omar-albastami omar-albastami merged commit 347f6fb into IBM:main Nov 10, 2023
2 checks passed
briangleeson pushed a commit that referenced this pull request Nov 10, 2023
@semantic-release-bot
chore(release): 1.4.0 release notes
544609a 
# [1.4.0](v1.3.1...v1.4.0) (2023-11-10)

### Bug Fixes

* dir fix to Makefile ([22f0f55](22f0f55))

### Features

* bump SDK version ([#38](#38)) ([347f6fb](347f6fb))
* support eu-es region ([#37](#37)) ([b79698d](b79698d)), closes [#35](#35)
@briangleeson
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omar-albastami @briangleeson