Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ROKS air-gapped clusters #850

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Support for ROKS air-gapped clusters #850

merged 10 commits into from
Dec 19, 2024

Conversation

fketelaars
Copy link
Collaborator

No description provided.

argeiger and others added 5 commits November 22, 2024 13:31
remove task calls for openshift-download-client

Remove openshift client download task

skip cli downloads when option set to true
address comments from review

address comments from review

address comments from review

address comments from review

address comments from review
skip-cli-download and change default case repository
Copy link

gitguardian bot commented Dec 10, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10070264 Triggered Generic Password 80e4449 automation-roles/50-install-cloud-pak/cp4ba/cp4ba-cluster/tasks/main.yml View secret
10070264 Triggered Generic Password d1114fc automation-roles/50-install-cloud-pak/cp4ba/cp4ba-cluster/tasks/main.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@fketelaars fketelaars merged commit aa1400d into main Dec 19, 2024
2 of 3 checks passed
@fketelaars fketelaars deleted the roks-airgapped branch December 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants