Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to run custom scripts through the cloud-pak-crontab-ds framework #572

Closed
semccombe opened this issue Oct 25, 2023 · 1 comment · Fixed by #612 or #619
Closed

Ability to run custom scripts through the cloud-pak-crontab-ds framework #572

semccombe opened this issue Oct 25, 2023 · 1 comment · Fixed by #612 or #619
Labels
finished-dev Finished development, waiting to be merged

Comments

@semccombe
Copy link

Is your feature request related to a problem? Please describe.
During a recent engagement, we needed to make additional changes to the RHCOS node-level configuration for the crio daemon.

We replicated the two CMs used by cloud-pak-deployer - namely cloud-pak-node-fix-config and cloud-pak-node-fix-scripts - to create a second pair of CMs. These were then mounted into the DS pod through an edit of the DS YAML, and were eventually copied into the RHCOS node by the DS command.

Finally, we made a manual change to the cloud-pak-node-fix.sh script at the node level to call our custom script. The next time the timer ran, our config change was copied to the crio config directory. We did this manually so as to reduce the risk of adding bad config to crio.

Describe the solution you'd like
I propose a generalization of this process, to be able to define and call custom scripts with the DS/CM/timer framework already used to configure ICSP and entitlements for ROKS clusters.

For this cluster, it would have been next to impossible to access the nodes without debug access. So, it was important not to introduce bad crio configuration to the node. If this capability were introduced, it may be important to test the systemctl restart crio command to ensure that crio comes back up successfully; if not a rollback may be in order.

Describe alternatives you've considered
This is the solution we quickly came up with to introduce a patch to the cluster. Not sure if this is the best approach.

@fketelaars
Copy link
Collaborator

Sorry, was incorrectly closed.

fketelaars added a commit that referenced this issue Jan 18, 2024
@fketelaars fketelaars added the finished-dev Finished development, waiting to be merged label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
finished-dev Finished development, waiting to be merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants