Skip to content

Commit

Permalink
Merge pull request #24 from ind1go/javadoc-warnings
Browse files Browse the repository at this point in the history
Fail build on Javadoc warnings
  • Loading branch information
ind1go authored Nov 6, 2019
2 parents c960184 + d2d45a3 commit 3760a5e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@
</goals>
</execution>
</executions>
<configuration>
<failOnWarnings>true</failOnWarnings>
</configuration>
</plugin>
<plugin>
<groupId>org.sonatype.plugins</groupId>
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/com/ibm/cics/bundle/parts/OsgiBundlePart.java
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ public static String convertMavenVersionToOSGiVersion(String mavenVersion) {

/**
* Gets the Bundle-Version header inside the given artifact's manifest.
* @param a The Artifact to find the Bundle-Version of
* @param osgiBundle The OSGi bundle file to find the Bundle-Version of
* @throws IOException if an I/O error has occurred
* @return The version or null if the manifest, or the header in the manifest, is not present
*/
public static String getBundleVersion(File osgiBundle) throws IOException {
Expand All @@ -72,7 +73,7 @@ public static String getBundleVersion(File osgiBundle) throws IOException {
* or will search inside a directory, if (as happens during incremental builds in the IDE), the artifact file
* is still pointing into the classes directory.
*
* @param a The file to read the manifest from
* @param osgiBundle The OSGi bundle file to find the Bundle-Version of
* @throws IOException if there was a problem reading the manifest
* @return The manifest, or null if none was found
*/
Expand Down

0 comments on commit 3760a5e

Please sign in to comment.