Add ImmutableConfig #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
gabe-l-hart
reviewed
Apr 24, 2023
Co-authored-by: Gabe Goodhart <gabe.l.hart@gmail.com> Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
gabe-l-hart
approved these changes
Apr 25, 2023
aconfig/aconfig.py
Outdated
| super().__init__(input_map) | ||
|
|
||
| def __setitem__(self, key, value): | ||
| raise AttributeError("ImmutableAttributeAccessDict does not support attribute assignment") |
There was a problem hiding this comment.
Heh, I actually think this should be a TypeError to keep with what happens if you try to use item assignment on a mappingproxy:
Foo.__dict__["asdf"] = 1
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'mappingproxy' object does not support item assignment
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
This PR adds an
ImmutableConfigwhich looks and feels like aConfig, but has fully nested immutability.We wanted to try using a
mappingproxybut unfortunately those are final and can't be extended. See related: https://stackoverflow.com/questions/66037137/immutable-frozen-dictionary-subclass-with-fixed-key-value-typesInstead we subclassed
AttributeAccessDictand removed the setters. Along with updating some static type references inAttributeAccessDicttoclsreferences to respect inheritance, this allows the recursive nesting to still happen but results in immutable dicts.