-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid storing the resource contents in the case of a soft delete #3293
Comments
this one has wide blast radius...
then: Rough manual test plan:
Then make sure all the following work:
|
I deployed this one to our cluster on IBM Cloud and ran the touchstone conformance tests against it. 100% successful. |
confirmed conditional delete is working as expected |
confirmed if-none-match and if-none-match within a bundle functionality |
confirmed $erase functionality |
issue #3439 has been addressed and this feature seems to be working |
Is your feature request related to a problem? Please describe.
In versioned FHIR servers (like ours), the DELETE action is a "soft delete"... its actually more like an update where we set the delete flag to Y.
Despite the resource content being logically deleted, for historical reasons we always write a new version of the entire resource payload in the db on this deleted version.
Describe the solution you'd like
Stop writing the resource payload on the deleted version of this record.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Acceptance Criteria
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]
Additional context
In a previous iteration of the DB, I think we always needed non-null data for the x_Resources tables.
We may have a few places that still assume you can read it back out (maybe audit?), but we think we can manage those.
The text was updated successfully, but these errors were encountered: