Take updates from upstream hashicorp #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermin class names
Change-Id: Ia1b26bf32d16628c3ef5cf99745ba7c222d3251e
This commit fixes an issue with security group rules where the rules were not being correctly computed due to a typo in the rule map. Once rules were successfully computed, the rules then needed to be converted into a Set so they can be correctly ordered.
providers/aws/structure
Add example of redrive_policy to docs. Fixes #2711.
providers/aws: Fix issue with removing access_logs from ELB
provider/aws: add support for group name and path changes with group update function
allow spaces in db subnet name
…cleanup provider/openstack: Clean up some attributes in LBaaS VIP resource
provider/aws: remove build-blocking unused variable.
This is shorthand to build and install the core of terraform, without touching the providers.
Add `core` target to Makefile
docs: fix template_file syntax error
…-updates Update docs to reflect vsphere provider only supporting IPv4 addresses
provider/cloudstack docs: use underscore in virtual machine attribute
Because `aws_security_group_rule` resources are an abstraction on top of Security Groups, they must interact with the AWS Security Group APIs in a pattern that often results in lots of parallel requests interacting with the same security group. We've found that this pattern can trigger race conditions resulting in inconsistent behavior, including: * Rules that report as created but don't actually exist on AWS's side * Rules that show up in AWS but don't register as being created locally, resulting in follow up attempts to authorize the rule failing w/ Duplicate errors Here, we introduce a per-SG mutex that must be held by any security group before it is allowed to interact with AWS APIs. This protects the space between `DescribeSecurityGroup` and `Authorize*` / `Revoke*` calls, ensuring that no other rules interact with the SG during that span. The included test exposes the race by applying a security group with lots of rules, which based on the dependency graph can all be handled in parallel. This fails most of the time without the new locking behavior. I've omitted the mutex from `Read`, since it is only called during the Refresh walk when no changes are being made, meaning a bunch of parallel `DescribeSecurityGroup` API calls should be consistent in that case.
provider/aws: serialize SG rule access to fix race condition
providers/aws: Fix typo in error checking for IAM Policy Attachments
…ighted_basic to test in isolation
we need AWS keys now, not bintray keys
Reproduces the issue reported by @svanharmelen in #3964.
Add tests for JSON configuration parsing
scripts: check for the correct env vars in dist.sh
danielcbright
added a commit
that referenced
this pull request
Nov 19, 2015
Take updates from upstream hashicorp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.