EN template update bug fix, support spf and dkim verification method for custom email destination #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfor event-notifications resources
…for custom email destination
hkantare
reviewed
Jan 27, 2025
| "verification_type": &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Verification Method spf/dkim.", |
There was a problem hiding this comment.
Can we add validation on supported methods
There was a problem hiding this comment.
Added validator for the same in latest commit
| verifyCustomEmailDestinationConfiguration.SetID(parts[1]) | ||
| hasChangeverification := false | ||
|
|
||
| verifyCustomEmailDestinationConfiguration.SetType(d.Get("verification_type").(string)) | ||
|
|
||
| if ok := d.HasChanges("name", "description", "collect_failed_events", "config"); ok { |
There was a problem hiding this comment.
only when we have some changes on these fields we use verification_type?
During create we don't need this property
There was a problem hiding this comment.
Yes, it is only a update parameter, it's not needed at the time of creation
hkantare
reviewed
Jan 27, 2025
| @@ -17,6 +17,7 @@ resource "ibm_en_destination_custom_email" "custom_domain_en_destination" { | |||
| instance_guid = ibm_resource_instance.en_terraform_test_resource.guid | |||
| name = "Custom Email EN Destination" | |||
| type = "smtp_custom" | |||
| verification_type = "" | |||
There was a problem hiding this comment.
why we want to empty verification_type?
There was a problem hiding this comment.
I will correct documentation, it's optional parameter.
hkantare
reviewed
Jan 28, 2025
| @@ -231,6 +302,12 @@ func resourceIBMEnCustomEmailDestinationUpdate(context context.Context, d *schem | |||
|
|
|||
| options.SetInstanceID(parts[0]) | |||
| options.SetID(parts[1]) | |||
| verifyCustomEmailDestinationConfiguration.SetType(d.Get("verification_type").(string)) | |||
There was a problem hiding this comment.
why we need to add this here if you are adding as part of if d.HasChange("verification_type")
hkantare
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests Conducted:
Custom email destination creation:
Custom email destination Update for Verification Method:
Template update: