Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cloud Databases): always include host flavor with scaling requests #5882

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix(Cloud Databases): always include host flavor with scaling requests #5882

merged 3 commits into from
Dec 18, 2024

Conversation

omaraibrahim
Copy link
Collaborator

@omaraibrahim omaraibrahim commented Dec 17, 2024 •
edited by alexhemard
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

This was accidentally removed during Revert "feat(Cloud Databases): Update Database Password Complexity Validation". This is part of fix(Cloud Databases): always include host flavor with scaling requests.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstancePostgresGroup'
--- PASS: TestAccIBMDatabaseInstancePostgresGroup (2487.30s)

...

alexhemard
alexhemard approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@alexhemard alexhemard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Added successful Acceptance test to description

This was included as part of #5701 which was reverted

@omaraibrahim omaraibrahim merged commit d5beb7b into IBM-Cloud:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhemard alexhemard alexhemard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omaraibrahim @alexhemard