Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Diff User Tags #5844

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Custom Diff User Tags #5844

merged 1 commit into from
Dec 8, 2024

Conversation

michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Dec 3, 2024

Adding ResourcePowerUserTagsCustomizeDiff because ResourceTagsCustomizeDiff checks for tags but are using pi_user_tags.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPICaptureUserTags
--- PASS: TestAccIBMPICaptureUserTags (204.92s)
PASS

=== RUN   TestAccIBMPIImageUserTags
--- PASS: TestAccIBMPIImageUserTags (123.24s)
PASS

=== RUN   TestAccIBMPIInstanceUserTags
--- PASS: TestAccIBMPIInstanceUserTags (956.58s)
PASS

=== RUN   TestAccIBMPINetworkUserTags
--- PASS: TestAccIBMPINetworkUserTags (76.79s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupBasic
--- PASS: TestAccIBMPINetworkAddressGroupBasic (34.86s)
PASS

=== RUN   TestAccIBMPINetworkInterfaceBasic
--- PASS: TestAccIBMPINetworkInterfaceBasic (31.60s)
PASS

=== RUN   TestAccIBMPISPPUserTags
--- PASS: TestAccIBMPISPPUserTags (204.37s)
PASS

=== RUN   TestAccIBMPIInstanceSnapshotUserTags
--- PASS: TestAccIBMPIInstanceSnapshotUserTags (930.61s)
PASS

=== RUN   TestAccIBMPIVolumeUserTags
--- PASS: TestAccIBMPIVolumeUserTags (92.77s)
PASS

=== RUN   TestAccIBMPIWorkspaceUserTags
--- PASS: TestAccIBMPIWorkspaceUserTags (183.66s)
PASS

...

Add compute to tag
Add compute to tag, batch2

Remove custom diff
@michaelkad michaelkad added the service/Power Systems Issues related to Power Systems label Dec 3, 2024
@hkantare hkantare merged commit 9a70188 into master Dec 8, 2024
1 check passed
@Alexander-Kita Alexander-Kita deleted the power-user-tags branch January 8, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants