Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential null pointer bug in pi capture user tags during creation #5730

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Description:
Fixes bug where capture image data CRN was read even though it could be nil during user tag handling in the creation function, which would cause an error.

Output from acceptance testing:

=== RUN   TestAccIBMPICaptureBasic
--- PASS: TestAccIBMPICaptureBasic (81.80s)
PASS
=== RUN   TestAccIBMPICaptureUserTags
--- PASS: TestAccIBMPICaptureUserTags (124.27s)
PASS

@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Oct 16, 2024
@Alexander-Kita Alexander-Kita changed the title Fix null pointer bug in pi capture user tags during creation Fix potential null pointer bug in pi capture user tags during creation Oct 17, 2024
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve this.

@yussufsh yussufsh merged commit 03caa9e into IBM-Cloud:master Nov 5, 2024
1 check passed
@Alexander-Kita Alexander-Kita deleted the fix-nil-capture-tags branch November 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants