Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D,R] Network Security Group #5726

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[D,R] Network Security Group #5726

merged 1 commit into from
Oct 17, 2024

Conversation

michaelkad
Copy link
Collaborator

[R] Add NSG
[R] Add NSG Action
[R] Add NSG Member
[R] Add NSG Member test
[R] Add NSG Rule

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkSecurityGroupBasic
--- PASS: TestAccIBMPINetworkSecurityGroupBasic (33.51s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupMemberBasic
--- PASS: TestAccIBMPINetworkSecurityGroupMemberBasic (90.58s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupsDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupsDataSourceBasic (14.83s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupDataSourceBasic (15.99s)
PASS

 === RUN   TestAccIBMPINetworkSecurityGroupRuleBasic
--- PASS: TestAccIBMPINetworkSecurityGroupRuleBasic (36.51s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupRuleTCP
--- PASS: TestAccIBMPINetworkSecurityGroupRuleTCP (36.00s)
PASS

@michaelkad michaelkad added the service/Power Systems Issues related to Power Systems label Oct 14, 2024
@michaelkad
Copy link
Collaborator Author

@VaishnaviGopal , @yussufsh and @hkantare please help with reviewing this pr.

@michaelkad michaelkad force-pushed the network-security-group branch 3 times, most recently from 59620d0 to dc254ef Compare October 15, 2024 14:57
@michaelkad michaelkad changed the title [D] Network Security Group [D,R] Network Security Group Oct 15, 2024
hkantare
hkantare previously approved these changes Oct 16, 2024
View reviewed changes
@hkantare
Copy link
Collaborator

@michaelkad can we fix the conflict

@michaelkad
[D] Network Security Group
e0f7fc9 
[R] Add NSG
[R] Add NSG Action
[R] Add NSG Member
[R] Add NSG Member test
[R] Add NSG Rule

Sync go.mod with master

Update to 1.8.3

Add handle for 404
Add custom diff
update  custom diff
update  nil check

fix conflicts
@michaelkad
Copy link
Collaborator Author

@michaelkad can we fix the conflict

@hkantare conflicts fixed

@hkantare hkantare merged commit eae525f into master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

@yussufsh yussufsh Awaiting requested review from yussufsh

@VaishnaviGopal VaishnaviGopal Awaiting requested review from VaishnaviGopal

@ismirlia ismirlia Awaiting requested review from ismirlia

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelkad @hkantare