Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #5723

Merged
merged 3 commits into from
Oct 17, 2024
Merged

bug fix #5723

merged 3 commits into from
Oct 17, 2024

Conversation

Ramya-c4
Copy link
Contributor

@@ -77,75 +78,17 @@ func DataSourceIbmConfigAggregatorConfigurations() *schema.Resource {
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"about": &schema.Schema{
Type: schema.TypeList,
Type: schema.TypeMap,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with Typemap then we have limitation from Terraform only can hold only string type. If you have combination of multiple types (string ,int, bool) then this will not be compatible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fields of this attribute are of type string so there is no modification required.

@hkantare
Copy link
Collaborator

we shd have doc changes also

@Ramya-c4
Copy link
Contributor Author

we shd have doc changes also

The changes were made to modify the output, the input remains the same. So doc changes wouldn't be necessary.

@hkantare
Copy link
Collaborator

It requires doc changes since we changed the schema type check personal slack for more details

if err != nil {
return "", err
}
fmt.Println(string(jsonData))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this fmt stmt

@hkantare hkantare merged commit 75a7487 into IBM-Cloud:master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants