Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for defined_performance changes in is_volume #5694

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Oct 1, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

Changes in datasource :

  • ibm_is_volume
    • code
    • test
    • doc
=== RUN   TestAccIBMISVolumeDatasource_Sdp
--- PASS: TestAccIBMISVolumeDatasource_Sdp (56.36s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     57.975s
  • ibm_is_volume_profile
    • code
    • test
    • doc
=== RUN   TestAccIBMISVolumeProfileDataSource_sdpbasic
--- PASS: TestAccIBMISVolumeProfileDataSource_sdpbasic (20.01s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     21.625s
  • ibm_is_volume_profiles
    • code
    • test
    • doc
=== RUN   TestAccIBMISVolumeProfilesDataSource_Sdp
--- PASS: TestAccIBMISVolumeProfilesDataSource_Sdp (21.71s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     23.689s
  • ibm_is_volumes
    • code
    • test
    • doc
=== RUN   TestAccIBMIsVolumesDataSourceSdpBasic
--- PASS: TestAccIBMIsVolumesDataSourceSdpBasic (24.26s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     26.330s

Changes in resource :

  • ibm_is_instance_volume_attachment
    • code
    • test
    • doc
--- PASS: TestAccIBMISInstanceVolumeAttachment_sdpbasic (402.06s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     404.464s
  • ibm_is_instance
    • code
    • test
    • doc
=== RUN   TestAccIBMISInstance_sdpbasic
--- PASS: TestAccIBMISInstance_sdpbasic (280.03s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     281.689s
  • ibm_is_volume
    • code
    • test
    • doc
=== RUN   TestAccIBMISVolume_sdpUpdate
--- PASS: TestAccIBMISVolume_sdpUpdate (163.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     165.720s
=== RUN   TestAccIBMISVolume_sdp
--- PASS: TestAccIBMISVolume_sdp (103.81s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     105.876s

@uibm uibm marked this pull request as draft October 1, 2024 06:28
@uibm uibm marked this pull request as ready for review October 18, 2024 09:01
@uibm uibm requested a review from hkantare October 18, 2024 11:53
@hkantare hkantare merged commit 3c3af9b into IBM-Cloud:master Oct 18, 2024
1 check passed
@uibm uibm deleted the sdp branch October 18, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants