Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Catalog Management): support new offering version limit #5688

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

benbuchanan
Copy link
Contributor

Supports new method of fetching all versions of an offering when doing read offering. Also added support for updating version with patch version instead of using patch offering.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

Test results
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogBasic -timeout 700m
=== RUN   TestAccIBMCmCatalogBasic
--- PASS: TestAccIBMCmCatalogBasic (16.56s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmCatalogSimpleArgs
--- PASS: TestAccIBMCmCatalogSimpleArgs (20.93s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogDataSourceBasic -timeout 700m
=== RUN   TestAccIBMCmCatalogDataSourceBasic
--- PASS: TestAccIBMCmCatalogDataSourceBasic (15.78s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmCatalogDataSourceSimpleArgs
--- PASS: TestAccIBMCmCatalogDataSourceSimpleArgs (14.87s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingBasic -timeout 700m
=== RUN   TestAccIBMCmOfferingBasic
--- PASS: TestAccIBMCmOfferingBasic (13.74s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingSimpleArgs
--- PASS: TestAccIBMCmOfferingSimpleArgs (21.55s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingDataSourceBasic -timeout 700m
=== RUN   TestAccIBMCmOfferingDataSourceBasic
--- PASS: TestAccIBMCmOfferingDataSourceBasic (16.42s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingDataSourceSimpleArgs
--- PASS: TestAccIBMCmOfferingDataSourceSimpleArgs (16.74s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionBasic -timeout 700m
=== RUN   TestAccIBMCmVersionBasic
--- PASS: TestAccIBMCmVersionBasic (29.45s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmVersionSimpleArgs
--- PASS: TestAccIBMCmVersionSimpleArgs (16.33s)

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmVersionDataSourceSimpleArgs
--- PASS: TestAccIBMCmVersionDataSourceSimpleArgs (17.64s)

@hkantare hkantare merged commit e30b5c6 into IBM-Cloud:master Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants