Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resource] Deprecate Snapshot For Instance Snapshot #5675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Resource] Deprecate Snapshot For Instance Snapshot #5675

wants to merge 1 commit into from

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Sep 23, 2024 •
edited
Loading

Output from acceptance testing:

=== RUN   TestAccIBMPIInstanceSnapshotbasic
--- PASS: TestAccIBMPIInstanceSnapshotbasic (870.97s)
PASS

=== RUN   TestAccIBMPIInstanceSnapshotUserTags
--- PASS: TestAccIBMPIInstanceSnapshotUserTags (758.19s)
PASS

=== RUN   TestAccIBMPIInstanceSnapshotbasicV0
--- PASS: TestAccIBMPIInstanceSnapshotbasicV0 (990.81s)
PASS

=== RUN   TestAccIBMPIInstanceSnapshotUserTagsV0
--- PASS: TestAccIBMPIInstanceSnapshotUserTagsV0 (1033.34s)
PASS

@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Sep 23, 2024
@ismirlia ismirlia mentioned this pull request Sep 23, 2024
Closed
@ismirlia
Copy link
Collaborator Author

@hkantare @yussufsh Please review as part of power Q3 release.

yussufsh
yussufsh requested changes Oct 1, 2024
View reviewed changes
website/docs/r/pi_instance_snapshot.html.markdown Outdated Show resolved Hide resolved
ibm/provider/provider.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_snapshot_test.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_snapshot_test.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_snapshot_test.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_snapshot_test.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_snapshot_test.go Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_snapshot_test.go Outdated Show resolved Hide resolved
website/docs/r/pi_instance_snapshot.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_instance_snapshot.html.markdown Outdated Show resolved Hide resolved
@ismirlia
Copy link
Collaborator Author

ismirlia commented Oct 1, 2024 

--- PASS: TestAccIBMPIInstanceSnapshotbasic (1253.30s)
PASS

@ismirlia ismirlia requested a review from yussufsh October 1, 2024 16:48
Alexander-Kita
Alexander-Kita previously approved these changes Oct 2, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare Awaiting requested review from hkantare

@michaelkad michaelkad Awaiting requested review from michaelkad

@yussufsh yussufsh Awaiting requested review from yussufsh

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ismirlia @yussufsh @Alexander-Kita