Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasource] Add support_systems for sap profile #5670

Merged
merged 1 commit into from
Oct 13, 2024
Merged

[Datasource] Add support_systems for sap profile #5670

merged 1 commit into from
Oct 13, 2024

Conversation

ismirlia
Copy link
Collaborator

Output from acceptance testing:

=== RUN   TestAccIBMPISAPProfileDataSourceBasic
--- PASS: TestAccIBMPISAPProfileDataSourceBasic (10.83s)
PASS

=== RUN   TestAccIBMPISAPProfilesDataSourceBasic
--- PASS: TestAccIBMPISAPProfilesDataSourceBasic (9.42s)
PASS

@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Sep 23, 2024
@ismirlia ismirlia mentioned this pull request Sep 23, 2024
Closed
@ismirlia
Copy link
Collaborator Author

@hkantare @yussufsh Please review as part of power Q3 release.

michaelkad
michaelkad previously approved these changes Oct 1, 2024
View reviewed changes
yussufsh
yussufsh previously approved these changes Oct 11, 2024
View reviewed changes
@yussufsh
Copy link
Collaborator

@ismirlia please rebase & squash.

@michaelkad michaelkad dismissed stale reviews from yussufsh and themself via 99458a2 October 11, 2024 17:18
@yussufsh yussufsh merged commit fd29c53 into IBM-Cloud:master Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

@michaelkad michaelkad Awaiting requested review from michaelkad

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ismirlia @yussufsh @michaelkad @Alexander-Kita