[Resource] Add Volumes Bulk Attach and Detach #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismirlia
requested review from
yussufsh,
hkantare,
michaelkad and
Alexander-Kita
|
Reran acceptance tests |
ismirlia
force-pushed
the
volumes-bulk-att-detch
branch
from
6cb03cc
to
32ed835
Compare
Alexander-Kita
previously approved these changes
Oct 1, 2024
michaelkad
previously approved these changes
Oct 1, 2024
ismirlia
dismissed stale reviews from michaelkad and Alexander-Kita
via
8e63b84
ismirlia
force-pushed
the
volumes-bulk-att-detch
branch
from
32ed835
to
8e63b84
Compare
|
Please look at my comment on the similar feature of bulk volume delete. #5672 (comment) IMO attach and detach should be part of the same resource. The volumes attached should be maintained in the state when the resource is created and removed when the resource is deleted. Having two separate resources would make things worse with errors on the next runs. Imagine you would not want to write attach and detach code in the same flow, that does not make sense OR you would not want to keep attaching or detaching only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output from acceptance testing: