Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replication_pool_map to disaster recovery data sources (GRS) #5664

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add replication_pool_map to disaster recovery data sources (GRS) #5664

merged 1 commit into from
Oct 11, 2024

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_disaster_recovery_location:

=== RUN   TestAccIBMPIDisasterRecoveryLocationDataSourceBasic
--- PASS: TestAccIBMPIDisasterRecoveryLocationDataSourceBasic (5.74s)
PASS

pi_disaster_recovery_locations:

=== RUN   TestAccIBMPIDisasterRecoveryLocationsDataSourceBasic
--- PASS: TestAccIBMPIDisasterRecoveryLocationsDataSourceBasic (6.35s)
PASS

Description: Added replication_pool_map attribute to pi_disaster_recovery_location and pi_disaster_recovery_locations datasources.

@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Sep 23, 2024
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-disaster-recovery-d branch from 8560ded to 2c2739c Compare September 23, 2024 15:55
@Alexander-Kita
Copy link
Collaborator Author

@hkantare @yussufsh please review as part of power Q3 release.

ismirlia
ismirlia previously approved these changes Sep 23, 2024
View reviewed changes
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-disaster-recovery-d branch from 7677e30 to 9477eac Compare October 10, 2024 14:13
yussufsh
yussufsh approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yussufsh
Copy link
Collaborator

@Alexander-Kita please rebase.

@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-disaster-recovery-d branch from 9477eac to e2c4487 Compare October 11, 2024 15:54
@Alexander-Kita
Copy link
Collaborator Author

@yussufsh rebased

@yussufsh yussufsh merged commit 9928c93 into master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@michaelkad michaelkad michaelkad approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexander-Kita @yussufsh @michaelkad @ismirlia