New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unexpected topic state change and acceptance test #5620

Merged

hkantare merged 2 commits into IBM-Cloud:master from JunliWang:master

Sep 9, 2024

Contributor

JunliWang commented Sep 5, 2024

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

this PR fixes 2 issues:

ibm_event_streams_topic: unexpected state change kafka_brokers_sasl #3199, it returns sorted broker addresses, so topic state will not change.
Acceptance test: deprecated RC V1 api returns unexpected results and causes checkInstanceDestroy fails, replace it with RC V2 API and check state to be removed or pending_reclamation.

Output from acceptance testing:

$ TF_ACC=1 go test . -v '-run=TestAccIBMEventStreamsTopicResourceBasic'
=== RUN   TestAccIBMEventStreamsTopicResourceBasic
--- PASS: TestAccIBMEventStreamsTopicResourceBasic (87.77s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams    89.458s
...

JunliWang added 2 commits

September 5, 2024 10:56


          fix: unexpected state change for topic

6312b37


          fix: replace deprecated rc v1 API in instance check

f854f76

hkantare approved these changes

View reviewed changes

hkantare merged commit 4fc8775 into IBM-Cloud:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet