Deprecated ibm_resource_access_tag and replaced it with ibm_iam_access_tag. Fixed 5566 too. #5567
Conversation
|
|
||
| func ResourceIBMIamAccessTag() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Create: resourceIBMIamAccessTagCreate, |
There was a problem hiding this comment.
Can you upgrade the resource to use Context
https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema#CreateContextFunc
There was a problem hiding this comment.
The changes have been pushed. Can you re-check? Thank you
| if len(errMap) > 0 { | ||
| output, err := json.MarshalIndent(errMap, "", " ") | ||
| log.Printf("err is %s", err) | ||
| return fmt.Errorf("[ERROR] Error while creating access tag(%s) : %s", tagName, string(output)) |
There was a problem hiding this comment.
Can you upgrade the error logging mechanism as per new error framework
communicated recently Terraform slack channels
https://ibm-cloudplatform.slack.com/archives/C53NF5MB4/p1722606201652699
There was a problem hiding this comment.
The changes have been pushed. Can you re-check? Thank you
| @@ -45,7 +45,7 @@ Review the argument references that you can specify for your resource. | |||
|
|
|||
| - `resource_id` - (Required, String) The CRN of the resource on which the tags is be attached. | |||
| - `resource_type` - (Optional, String) The resource type on which the tags should be attached. | |||
| - `tag_type` - (Optional, String) Type of the tag. Supported values are: `user`, `service`, or `access`. The default value is user. | |||
There was a problem hiding this comment.
Why was servicetag type removed
There was a problem hiding this comment.
We decided to remove the service tag due to the fact that the service tag is used in IBM internally only and only a little set of users can use it. So it should not be exposed in the documentation.
|
All the above changes have been addresses. |
…s_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes
Community Note
Relates OR Closes #5566
Relates OR Closes #5522
This PR addresses #5522 and #5566
The
ibm_resource_access_tagterraform resource has been deprecated and replaced with theibm_iam_access_tagterraform resource. We just renamed it with the new name following the decision here: #5522 (comment)With this PR we fixed the #5566 too.
Reworked the tests in order to use a resource that requires less time to be provisioned.
Output from acceptance testing:
Test about the fix in the
ibm_resource_tagterraform resource about #5566Test about the
ibm_iam_access_tagterraform resource:We used the
-count=1flag to avoid the usage of the case.