-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KMS] Force delete subresources during kmip_adapter destroy, avoid casting panics #5565
[KMS] Force delete subresources during kmip_adapter destroy, avoid casting panics #5565
Conversation
Unit Tests
Manual TestsBehavior of kmip_adapter destroy prior to this change (failure due to active kmip object under adapter):
Behavior of kmip_adapter destroy with this change (succeeds despite active kmip object under adapter):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Thank you!
Update kmip_adapter destroy behavior to force delete kmip_objects under the kmip_adapter to be destroyed. This will minimize scenarios where kmip_adapter parent resources cannot be destroyed to cleaned up due to failure to destroy kmip_adapter under parent resource.
Also updated areas of casting vars without validation (prevents potential panics)
Community Note
Relates OR Closes #0000
Output from acceptance testing: