Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SM New error formatting + crypto_key label name changes #5562

Merged
merged 70 commits into from
Sep 11, 2024
Merged

SM New error formatting + crypto_key label name changes #5562

merged 70 commits into from
Sep 11, 2024

Conversation

yonatanyell
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Yonathan-Yellin and others added 30 commits November 15, 2023 13:19
SC addition
317590f
SC addition
babc0f9
SC addition
8071667
update function updated
60abaf9
SC unit tests added
8477dde
@yonatanyell
Merge branch 'IBM-Cloud:master' into master
2f38ba5
SC unit tests added
972a9b9
d
59c5e72
tests fixes
2ff98ad
Merge remote-tracking branch 'origin/master'
b9e8416
tests fixes
40ea122
@TatyanaBol
update sdk
f3a195f
.secrets.baseline update
8fa09ae
.secrets.baseline update
a6b779c
@yonatanyell
Merge branch 'master' into master
1f1e01a
.secrets.baseline update
cea9bd4
Merge remote-tracking branch 'origin/master'
0d333f9
@IdanAdar
Update sm_service_credentials_secret_metadata.html.markdown
ad75820
Merge branch 'master' of github.com:yonatanyell/terraform-provider-ibm
5ece471 
� Conflicts:
�	.secrets.baseline
bugs fixes
e91f429
bugs fixes
c44ff91
bugs fixes
74626d8
@yonatanyell
Merge branch 'master' into master
bd730d7
docs bugs fixes
fbf61c6
Merge remote-tracking branch 'origin/master'
fbc7294
@yonatanyell
Merge branch 'IBM-Cloud:master' into master
25f8094
preferred_chain added for public cert lets encrypt configuration
e63a564
@yonatanyell
Merge branch 'IBM-Cloud:master' into master
daa771b
support for creating secret version for username password & version_c…
ef612d9 
…ustom_metadata for all
Merge remote-tracking branch 'origin/master'
6e7b866
Yonathan-Yellin and others added 17 commits May 22, 2024 14:26
name regex fix in docs
3af4490
@yonatanyell
Merge branch 'IBM-Cloud:master' into master
6b01f8b
imported cert bug fix
edde88e
@yonatanyell
Merge branch 'master' into master
c6f5e63
crypto_key addition
bcf6e76
crypto_key addition
85ab27f
crypto_key addition
34d9371
@yonatanyell
Merge branch 'IBM-Cloud:master' into master
11133eb
crypto_key addition
1f27098
rejections fixes
6f8fe14
rejections fixes
4670c91
rejections fixes
c8972f5
rejections fixes
9b77d30
rejections fixes
7fe57d1
test label name changed
5c6ca94
test label name changed
d1864d7
Merge branch 'master' of github.com:yonatanyell/terraform-provider-ibm
90e5cfb 
� Conflicts:
�	ibm/service/secretsmanager/resource_ibm_sm_private_certificate_configuration_intermediate_ca_test.go
�	ibm/service/secretsmanager/resource_ibm_sm_private_certificate_configuration_root_ca_test.go
@yonatanyell yonatanyell requested a review from hkantare August 19, 2024 14:21
@yonatanyell
Copy link
Collaborator Author

@hkantare This PR also includes now the changes of the error formatting, as requested here

@yonatanyell yonatanyell changed the title SM crypto_key label name changes SM New error formatting + crypto_key label name changes Sep 2, 2024
@yonatanyell
Copy link
Collaborator Author

=== RUN TestAccIbmSmArbitrarySecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmArbitrarySecretMetadataDataSourceBasic (43.16s)
=== RUN TestAccIbmSmArbitrarySecretDataSourceBasic
--- PASS: TestAccIbmSmArbitrarySecretDataSourceBasic (39.69s)
=== RUN TestAccIbmSmConfigurationsDataSourceBasic
--- PASS: TestAccIbmSmConfigurationsDataSourceBasic (51.42s)
=== RUN TestAccIbmSmConfigurationsDataSourceCryptoKey
--- PASS: TestAccIbmSmConfigurationsDataSourceCryptoKey (81.70s)
=== RUN TestAccIbmSmEnRegistrationDataSourceBasic
--- PASS: TestAccIbmSmEnRegistrationDataSourceBasic (35.65s)
=== RUN TestAccIbmSmIamCredentialsConfigurationDataSourceBasic
--- PASS: TestAccIbmSmIamCredentialsConfigurationDataSourceBasic (36.69s)
=== RUN TestAccIbmSmIamCredentialsSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmIamCredentialsSecretMetadataDataSourceBasic (44.47s)
=== RUN TestAccIbmSmIamCredentialsSecretDataSourceBasic
--- PASS: TestAccIbmSmIamCredentialsSecretDataSourceBasic (41.72s)
=== RUN TestAccIbmSmImportedCertificateMetadataDataSourceBasic
--- PASS: TestAccIbmSmImportedCertificateMetadataDataSourceBasic (31.61s)
=== RUN TestAccIbmSmImportedCertificateDataSourceBasic
--- PASS: TestAccIbmSmImportedCertificateDataSourceBasic (31.68s)
=== RUN TestAccIbmSmKvSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmKvSecretMetadataDataSourceBasic (39.28s)
=== RUN TestAccIbmSmKvSecretDataSourceBasic
--- PASS: TestAccIbmSmKvSecretDataSourceBasic (39.91s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCADataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCADataSourceBasic (42.83s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCADataSourceCryptoKey
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCADataSourceCryptoKey (72.15s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCADataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCADataSourceBasic (37.62s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCADataSourceCryptoKey
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCADataSourceCryptoKey (57.97s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationTemplateDataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationTemplateDataSourceBasic (40.83s)
=== RUN TestAccIbmSmPrivateCertificateMetadataDataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateMetadataDataSourceBasic (49.32s)
=== RUN TestAccIbmSmPrivateCertificateDataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateDataSourceBasic (51.19s)
=== RUN TestAccIbmSmPublicCertificateConfigurationCALetsEncryptDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationCALetsEncryptDataSourceBasic (35.92s)
=== RUN TestAccIbmSmPublicCertificateConfigurationDnsCisDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationDnsCisDataSourceBasic (34.50s)
=== RUN TestAccIbmSmPublicCertificateConfigurationDnsClassicInfrastructureDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationDnsClassicInfrastructureDataSourceBasic (35.59s)
=== RUN TestAccIbmSmPublicCertificateMetadataDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateMetadataDataSourceBasic (150.93s)
=== RUN TestAccIbmSmPublicCertificateDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateDataSourceBasic (155.60s)
=== RUN TestAccIbmSmSecretGroupDataSourceBasic
--- PASS: TestAccIbmSmSecretGroupDataSourceBasic (36.34s)
=== RUN TestAccIbmSmSecretGroupDataSourceAllArgs
--- PASS: TestAccIbmSmSecretGroupDataSourceAllArgs (33.82s)
=== RUN TestAccIbmSmSecretGroupsDataSourceBasic
--- PASS: TestAccIbmSmSecretGroupsDataSourceBasic (36.83s)
=== RUN TestAccIbmSmSecretGroupsDataSourceAllArgs
--- PASS: TestAccIbmSmSecretGroupsDataSourceAllArgs (33.83s)
=== RUN TestAccIbmSmSecretsDataSourceBasic
--- PASS: TestAccIbmSmSecretsDataSourceBasic (43.83s)
=== RUN TestAccIbmSmServiceCredentialsSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmServiceCredentialsSecretMetadataDataSourceBasic (40.29s)
=== RUN TestAccIbmSmServiceCredentialsSecretDataSourceBasic
--- PASS: TestAccIbmSmServiceCredentialsSecretDataSourceBasic (42.08s)
=== RUN TestAccIbmSmUsernamePasswordSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmUsernamePasswordSecretMetadataDataSourceBasic (35.06s)
=== RUN TestAccIbmSmUsernamePasswordSecretDataSourceBasic
--- PASS: TestAccIbmSmUsernamePasswordSecretDataSourceBasic (38.73s)
=== RUN TestAccIbmSmArbitrarySecretBasic
--- PASS: TestAccIbmSmArbitrarySecretBasic (37.02s)
=== RUN TestAccIbmSmArbitrarySecretAllArgs
--- PASS: TestAccIbmSmArbitrarySecretAllArgs (64.80s)
=== RUN TestAccIbmSmEnRegistrationBasic
--- PASS: TestAccIbmSmEnRegistrationBasic (33.23s)
=== RUN TestAccIbmSmIamCredentialsConfigurationBasic
--- PASS: TestAccIbmSmIamCredentialsConfigurationBasic (37.15s)
=== RUN TestAccIbmSmIamCredentialsSecretBasic
--- PASS: TestAccIbmSmIamCredentialsSecretBasic (48.75s)
=== RUN TestAccIbmSmIamCredentialsSecretAllArgs
--- PASS: TestAccIbmSmIamCredentialsSecretAllArgs (81.12s)
=== RUN TestAccIbmSmImportedCertificateBasic
--- PASS: TestAccIbmSmImportedCertificateBasic (38.55s)
=== RUN TestAccIbmSmImportedCertificateAllArgs
--- PASS: TestAccIbmSmImportedCertificateAllArgs (67.20s)
=== RUN TestAccIbmSmKvSecretBasic
--- PASS: TestAccIbmSmKvSecretBasic (37.14s)
=== RUN TestAccIbmSmKvSecretAllArgs
--- PASS: TestAccIbmSmKvSecretAllArgs (65.12s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationActionSetSignedBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationActionSetSignedBasic (37.62s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationActionSignCsrBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationActionSignCsrBasic (35.51s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCABasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCABasic (41.84s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCAllArgs
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCAllArgs (66.12s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCACryptoKey
--- FAIL: TestAccIbmSmPrivateCertificateConfigurationIntermediateCACryptoKey (33.97s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCABasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCABasic (36.45s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCAllArgs
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCAllArgs (63.61s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCACryptoKey
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCACryptoKey (63.37s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationTemplateBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationTemplateBasic (44.97s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationTemplateAllArgs
--- PASS: TestAccIbmSmPrivateCertificateConfigurationTemplateAllArgs (72.73s)
=== RUN TestAccIbmSmPrivateCertificateBasic
--- PASS: TestAccIbmSmPrivateCertificateBasic (49.99s)
=== RUN TestAccIbmSmPrivateCertificateAllArgs
--- PASS: TestAccIbmSmPrivateCertificateAllArgs (80.66s)
=== RUN TestAccIbmSmPublicCertificateActionValidateManualDnsBasic
--- PASS: TestAccIbmSmPublicCertificateActionValidateManualDnsBasic (400.51s)
=== RUN TestAccIbmSmPublicCertificateConfigurationCALetsEncryptBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationCALetsEncryptBasic (34.89s)
=== RUN TestAccIbmSmConfigurationPublicCertificateDnsCisBasic
--- PASS: TestAccIbmSmConfigurationPublicCertificateDnsCisBasic (36.21s)
=== RUN TestAccIbmSmPublicCertificateConfigurationDNSClassicInfrastructureBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationDNSClassicInfrastructureBasic (35.80s)
=== RUN TestAccIbmSmPublicCertificateBasic
--- PASS: TestAccIbmSmPublicCertificateBasic (154.10s)
=== RUN TestAccIbmSmPublicCertificateAllArgs
--- PASS: TestAccIbmSmPublicCertificateAllArgs (186.57s)
=== RUN TestAccIbmSmSecretGroupBasic
--- PASS: TestAccIbmSmSecretGroupBasic (57.61s)
=== RUN TestAccIbmSmSecretGroupAllArgs
--- PASS: TestAccIbmSmSecretGroupAllArgs (59.50s)
=== RUN TestAccIbmSmServiceCredentialsSecretBasic
--- PASS: TestAccIbmSmServiceCredentialsSecretBasic (44.00s)
=== RUN TestAccIbmSmServiceCredentialsSecretAllArgs
--- PASS: TestAccIbmSmServiceCredentialsSecretAllArgs (69.49s)
=== RUN TestAccIbmSmServiceCredentialsSecretAllArgsWithExistingServiceId
--- PASS: TestAccIbmSmServiceCredentialsSecretAllArgsWithExistingServiceId (43.92s)
=== RUN TestAccIbmSmUsernamePasswordSecretBasic
--- PASS: TestAccIbmSmUsernamePasswordSecretBasic (40.39s)
=== RUN TestAccIbmSmUsernamePasswordSecretAllArgs
--- PASS: TestAccIbmSmUsernamePasswordSecretAllArgs (66.91s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/secretsmanager 3990.924s

@IdanAdar IdanAdar added the service/Secrets Manager Issues related to Secrets Manager label Sep 11, 2024
@hkantare hkantare merged commit 83b1061 into IBM-Cloud:master Sep 11, 2024
1 check passed
srikant-sahu pushed a commit to srikant-sahu/terraform-provider-ibm that referenced this pull request Sep 24, 2024
@yonatanyell @TatyanaBol @IdanAdar
SM New error formatting + crypto_key label name changes (IBM-Cloud#5562)
0f2c1f8 
* SC addition

* SC addition

* SC addition

* update function updated

* SC unit tests added

* SC unit tests added

* d

* tests fixes

* tests fixes

* update sdk

* .secrets.baseline update

* .secrets.baseline update

* .secrets.baseline update

* Update sm_service_credentials_secret_metadata.html.markdown

* bugs fixes

* bugs fixes

* bugs fixes

* docs bugs fixes

* preferred_chain added for public cert lets encrypt configuration

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* preferred chain docs update

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* support for creating secret version for username password & version_custom_metadata for all

* fix public cert bug

* update docs

* reordering bug in alt_names

* name regex fix in docs

* imported cert bug fix

* crypto_key addition

* crypto_key addition

* crypto_key addition

* crypto_key addition

* rejections fixes

* rejections fixes

* rejections fixes

* rejections fixes

* rejections fixes

* test label name changed

* test label name changed

* error formating update

* go sdk version update

---------

Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com>
Co-authored-by: Avi Ribchinsky <avir@il.ibm.com>
Co-authored-by: Tatyana <tatyanab@il.ibm.com>
Co-authored-by: Idan Adar <iadar@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees

@yonatanyell yonatanyell

Labels
service/Secrets Manager Issues related to Secrets Manager
Projects
IBM Cloud Terraform Provider
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yonatanyell @hkantare @IdanAdar @TatyanaBol