Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read endpoint type from schema #5552

Merged
merged 3 commits into from
Aug 9, 2024
Merged

fix: read endpoint type from schema #5552

merged 3 commits into from
Aug 9, 2024

Conversation

IBM-Deeksha
Copy link
Contributor

Fix: Read endpoint from schema instead of fake generated bucketid.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hkantare hkantare merged commit 59a6f73 into IBM-Cloud:master Aug 9, 2024
1 check passed
Alexander-Kita pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Aug 13, 2024
@IBM-Deeksha @Alexander-Kita
fix: read endpoint type from schema (IBM-Cloud#5552)
b2c0df1 
* fix: read endpoint type from schema

* add empty string check

* update code

---------

Co-authored-by: Deeksha Sharma <deekshasharma@Deekshas-MacBook-Pro.local>
Alexander-Kita pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Aug 13, 2024
@IBM-Deeksha @Alexander-Kita
fix: read endpoint type from schema (IBM-Cloud#5552)
9adba32 
* fix: read endpoint type from schema

* add empty string check

* update code

---------

Co-authored-by: Deeksha Sharma <deekshasharma@Deekshas-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinash1IBM avinash1IBM avinash1IBM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IBM-Deeksha @avinash1IBM @hkantare