-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2S documentation note for ibm_kms_key and minor linting fixes #5529
S2S documentation note for ibm_kms_key and minor linting fixes #5529
Conversation
Unit test run:
Re-ran failed test case:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup
website/docs/r/kms_key.html.markdown
Outdated
@@ -12,6 +12,8 @@ This resource can be used for management of keys in both Key Protect and Hyper P | |||
|
|||
After creating an Hyper Protect Crypto Service instance you need to initialize the instance properly with the crypto units, in order to create, or manage Hyper Protect Crypto Service keys. For more information, about how to initialize the Hyper Protect Crypto Service instance, see [Initialize Hyper Protect Crypto](https://cloud.ibm.com/docs/hs-crypto?topic=hs-crypto-initialize-hsm) only for HPCS instance. | |||
|
|||
~>**Important:** | |||
If the key is used with other IBM Cloud resources that require an `ibm_iam_authorization_policy` resource (requires [service authorization](https://cloud.ibm.com/docs/account?topic=account-serviceauth&interface=ui)), make sure to include `depends_on` targing the `ibm_iam_authorization_policy` involved to ensure proper deletion of resources with `terraform destroy`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
targing -> targeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to clarify whether the depends on should be establish from iam to policy to key or kms instance.
If possible, maybe an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated spelling and added link to new example usage section for S2S policy setup
Fixed failing
|
Community Note
Relates OR Closes N/A
Output from acceptance testing: