Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update for ODF #5454

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Doc update for ODF #5454

merged 3 commits into from
Jul 18, 2024

Conversation

gayathrimenath-ibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@gayathrimenath-ibm
Copy link
Contributor Author

@akgunjal @derekpoindexter Please review

akgunjal
akgunjal approved these changes Jun 20, 2024
View reviewed changes
Copy link

@akgunjal akgunjal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gayathrimenath-ibm
Copy link
Contributor Author

@aayushsss1 Please review the changes

aayushsss1
aayushsss1 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@aayushsss1 aayushsss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gayathrimenath-ibm @derekpoindexter
Update examples/openshift-data-foundation/README.md
c74c506 
Co-authored-by: derekpoindexter <45565883+derekpoindexter@users.noreply.github.com>
@hkantare hkantare merged commit 4a0fdce into IBM-Cloud:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekpoindexter derekpoindexter derekpoindexter left review comments

@akgunjal akgunjal akgunjal approved these changes

@hkantare hkantare hkantare approved these changes

@aayushsss1 aayushsss1 aayushsss1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gayathrimenath-ibm @akgunjal @hkantare @derekpoindexter @aayushsss1