Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CatalogManagement): remove deprecated arguments not supported in latest sdk #5405

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

benbuchanan
Copy link
Contributor

PR to remove deprecated catalog management offering fields. Newest SDK doesn't support these values anymore so they need to be removed.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccIBMCmOfferingSimpleArgs'
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIBMCmOfferingSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingSimpleArgs
--- PASS: TestAccIBMCmOfferingSimpleArgs (33.84s)

make testacc TESTARGS='-run=TestAccIBMCmOfferingDataSourceSimpleArgs'
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIBMCmOfferingDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingDataSourceSimpleArgs
--- PASS: TestAccIBMCmOfferingDataSourceSimpleArgs (24.91s)

@benbuchanan
Copy link
Contributor Author

@hkantare

@benbuchanan
Copy link
Contributor Author

@hkantare Including additional fix in this PR to allow the required_resources field to be set on a version.

Testing output

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionComplexArgs -timeout 700m
=== RUN   TestAccIBMCmVersionComplexArgs
--- PASS: TestAccIBMCmVersionComplexArgs (21.53s)

@hkantare hkantare merged commit c4e1e34 into IBM-Cloud:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants