Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cloud Databases):Incorporate new client-error-toolchain in data sources #5320

Merged
merged 6 commits into from
May 2, 2024

Conversation

lornakelly
Copy link
Contributor

@lornakelly lornakelly commented May 1, 2024

Currently we are using an outdated way of deal with errors

This PR will:

  • Update our data sources to use the new client-error-toolchain
  • Fix for a hardcoded location in a test

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseBackupDataSourceBasic'
--- PASS: TestAccIBMDatabaseBackupDataSourceBasic (18.64s)

$ make testacc TESTARGS='-run=TestAccIBMDatabaseBackupsDataSourceBasic'
--- PASS: TestAccIBMDatabaseBackupsDataSourceBasic (14.93s)

$ make testacc TESTARGS='-run=TestAccIBMDatabasePointInTimeRecoveryDataSourceBasic'
--- PASS: TestAccIBMDatabasePointInTimeRecoveryDataSourceBasic (638.15s)

$ make testacc TESTARGS='-run=TestAccIBMDatabaseTasksDataSourceBasic'
--- PASS: TestAccIBMDatabasePointInTimeRecoveryDataSourceBasic (638.15s)

$ make testacc TESTARGS='-run=TestAccIBMDatabaseDataSource_basic'
--- PASS: TestAccIBMDatabaseDataSource_basic (681.04s)

$ make testacc TESTARGS='-run=TestAccIBMDatabaseConnectionDataSourceBasic'
--- PASS: TestAccIBMDatabaseConnectionDataSourceBasic (696.35s)

...

}

return nil
}

// DataSourceIBMDatabaseBackupsID returns a reasonable ID for the list.
// dataSourceIBMDatabaseBackupsID returns a reasonable ID for the list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to capitalize this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -8,7 +8,7 @@ require (
github.com/IBM/apigateway-go-sdk v0.0.0-20210714141226-a5d5d49caaca
github.com/IBM/appconfiguration-go-admin-sdk v0.3.0
github.com/IBM/appid-management-go-sdk v0.0.0-20210908164609-dd0e0eaf732f
github.com/IBM/cloud-databases-go-sdk v0.6.0
github.com/IBM/cloud-databases-go-sdk v0.7.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this sdk version released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obai-1 obai-1 merged commit de1a463 into IBM-Cloud:master May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants