update observability to use masterHealth check

[bhpratt]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes issue where observability is failing to install on a provisioning cluster. The observability plugin has a built-in check to see that masterHealth is normal. In edge cases with terraform and a provisioning cluster, the provider is attempting to install the plugin before the master is ready - this causes terraform to exit with an error.

Adding the check to masterHealth will give the master time to finish creating and then observability will be installed.

Summary of main changes:

• update bluemix-go version to pull in new masterHealth field
• change check to use masterHealth field for both VPC and Classic infra clusters
• gofmt to fix pre-existing formatting issues fixed elsewhere

Output from acceptance testing:

$ make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMLogging_basic'
=== RUN   TestAccIBMLogging_basic
--- PASS: TestAccIBMLogging_basic (1094.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1095.630s
...

I have also built the provider and tested locally w/classic and vpc clusters. It waits as expected until masterHealth is normal

[hkantare]

can the PR rebased on top of master

[bhpratt]

@hkantare done