Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature is sg rule local ip #5244

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

SunithaGudisagarIBM1
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISSecurityGroupRule_basic'
...
Screenshot 2024-01-29 at 10 44 08 AM
resource "ibm_is_security_group_rule" "testacc_security_group_rule_tcp_any" {
  group     = "r134-a2f82965-1b8d-4bfe-9949-fe79e47daa86"
  local     = "192.168.3.4"
  direction = "inbound"
  remote    = "127.0.0.1"
  tcp {
  }
}

data "ibm_is_security_group_rule" "example" {
  security_group_rule = "r134-cbee5b37-3fa3-4c33-beff-608a1855efe0"
  security_group      = "r134-a2f82965-1b8d-4bfe-9949-fe79e47daa86"
}

data "ibm_is_security_group_rules" "examples" {
  security_group      = "r134-a2f82965-1b8d-4bfe-9949-fe79e47daa86"
}

data "ibm_is_security_group" "sg1_rule" {
  name = "concrete-proudly-coastal-obvious"
}

data "ibm_is_security_groups" "example" {
}

Screenshot 2024-01-27 at 5 34 15 PM Screenshot 2024-01-29 at 8 38 40 AM Screenshot 2024-01-29 at 8 46 02 AM Screenshot 2024-01-29 at 10 17 15 AM Screenshot 2024-01-29 at 10 26 01 AM

@SunithaGudisagarIBM1
Copy link
Contributor Author

=== RUN TestAccIBMISSecurityGroupRule_basic
--- PASS: TestAccIBMISSecurityGroupRule_basic (103.08s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc 104.668s
sunitha@Sunithas-MacBook-Pro terraform-provider-ibm %

@hkantare hkantare merged commit b8c55bb into IBM-Cloud:master Mar 28, 2024
1 check passed
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
* SDK Changes

* Development and Documentation

* Added test and maturity param

* SDK update

* SDK update

* Go Version Update

* REview comments incorporated
@SunithaGudisagarIBM1 SunithaGudisagarIBM1 deleted the feature-is-sg-rule-local-ip branch July 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants