Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GO RC SDK v2 migration #5214

Merged
merged 2 commits into from
Mar 22, 2024
Merged

GO RC SDK v2 migration #5214

merged 2 commits into from
Mar 22, 2024

Conversation

IBM-diksha
Copy link
Collaborator

@IBM-diksha IBM-diksha commented Mar 19, 2024 •
edited
Loading

Test cases :

--- PASS: TestAccIBMCosBucket_Basic (154.25s)

--- PASS: TestAccIBMCosBucket_Basic_Single_Site_Location (81.07s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 243.946s

-- PASS: TestAccIBMCosBucket_AllowedIP (116.93s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 122.044s

--- PASS: TestAccIBMCosBucket_ActivityTracker_Monitor (120.16s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 123.591s

--- PASS: TestAccIBMCOSBucketDataSource_basic (47.68s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 52.673s

hkantare
hkantare reviewed Mar 21, 2024
View reviewed changes
ibm/service/cos/data_source_ibm_cos_bucket.go Outdated
return err
}

authenticator := new(core.IamAuthenticator)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we intializing authenticator here. It should be in config.go similar to CosConfigV1API()
Every time only APIkey is n't used to work with provider.
The provider can work with IAM tokens (in Schematics)

@IBM-diksha
Copy link
Collaborator Author

Latest test cases :
--- PASS: TestAccIBMCosBucket_Basic_Single_Site_Location (109.80s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 286.347s
--- PASS: TestAccIBMCosBucket_Basic (169.83s)
--- PASS: TestAccIBMCosBucket_AllowedIP (181.22s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 187.944s
--- PASS: TestAccIBMCosBucket_ActivityTracker_Monitor (189.45s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 196.427s

--- PASS: TestAccIBMCOSBucketDataSource_basic (65.55s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 68.543s

@hkantare hkantare merged commit 3289e78 into IBM-Cloud:master Mar 22, 2024
1 check passed
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
@IBM-diksha @ismirlia
GO RC SDK v2 migration (IBM-Cloud#5214)
0f30539 
* Updating the IBM COS SDK GO RC to v2

* Addressing the review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinash1IBM avinash1IBM avinash1IBM approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IBM-diksha @hkantare @avinash1IBM