Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cloud connection refactor data source and documentation #5053

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

Diptipowervs
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@michaelkad michaelkad added the service/Power Systems Issues related to Power Systems label Jan 18, 2024
@yussufsh
Copy link
Collaborator

@Diptipowervs please run and paste the test results here.

@Diptipowervs
Copy link
Contributor Author

@Diptipowervs please run and paste the test results here.
After making commit.The output is as below

--- PASS: TestAccIBMPICloudConnectionDataSource_basic (153.76s)
PASS

website/docs/d/pi_cloud_connections.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_cloud_connections.html.markdown Outdated Show resolved Hide resolved
- `region` - `lon`
- `zone` - `lon04`

Example usage:

Example usage:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is part of the second bullet point—no need to remove a tab.

Copy link
Collaborator

@ismirlia ismirlia Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same problem that was in the image list catalog refactor. This is a common problem for 90% of the existing markdown files.

The change changes it from:
Screenshot 2024-01-24 at 9 08 16 AM

to:
Screenshot 2024-01-24 at 9 09 01 AM

data "ibm_pi_cloud_connection" "example" {
pi_cloud_connection_name = "%s"
pi_cloud_instance_id = "%s"
}`, acc.PiCloudConnectionName, acc.Pi_cloud_instance_id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a new line?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a new line, this part of the same line. The line number is the same, but view is squished so it appears to be on a new line.

@yussufsh
Copy link
Collaborator

@ismirlia lgtm, but would like your review as well.

Diptipowervs and others added 2 commits January 24, 2024 14:27
Co-authored-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
Co-authored-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@hkantare hkantare merged commit b09f65d into IBM-Cloud:master Jan 30, 2024
1 check passed
@Diptipowervs
Copy link
Contributor Author

Diptipowervs commented Feb 6, 2024

--- PASS: TestAccIBMPICloudConnectionDataSource_basic (30.26s)
PASS
--- PASS: TestAccIBMPICloudConnectionsDataSourceBasic (29.66s)
PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants